AfRA/AfRApay

Fork 0

Implement card deletion #19

New issue

Closed

opened 2023-02-10 02:43:30 +01:00 by zotan · 3 comments

zotan commented

2023-02-10 02:43:30 +01:00

Owner

No description provided.

zotan added this to the AfRApay rev2 milestone 2023-02-10 02:43:59 +01:00

zotan self-assigned this 2023-02-10 02:44:10 +01:00

zotan referenced this issue from a commit

2023-02-10 17:16:38 +01:00

Move actions to POST handlers, fixes #15 and partially implements #19

zotan commented

2023-02-10 17:18:21 +01:00

Author

Owner

This still needs a confirmation dialog

zotan added the

sw/Web

label 2023-02-10 17:55:29 +01:00

zotan added the

missing core feature

label 2023-02-10 17:57:29 +01:00

zotan changed title from ~~.Web - Implement card deletion~~ to Implement card deletion

2023-02-10 18:12:50 +01:00

enbyfoxen referenced this issue from a commit

2023-02-10 22:48:27 +01:00

Basic deletion dialog implemented

enbyfoxen commented

2023-02-10 22:56:57 +01:00

Member

I've implemented a basic card deletion confirmation dialog.

Still need to actually render the card preview into the dialog.
As well as modifying async Task RenderCard(...) to render a card without the delete button nor blurring enabled.

Shouldn't be too difficult, but I'm struggling with not properly understanding C# here.

For now just displays the card number as a placeholder instead.

I've implemented a basic card deletion confirmation dialog. Still need to actually render the card preview into the dialog. As well as modifying [```async Task RenderCard(...)```](https://git.ztn.sh/AfRA/AfRApay/src/commit/d47a41454a5f701e16d83a891ff03e63de0bd636/AfRApay.Web/Pages/EditUser.cshtml#L62) to render a card without the delete button nor blurring enabled. Shouldn't be too difficult, but I'm struggling with not properly understanding C# here. For now just displays the card number as a placeholder instead.

enbyfoxen commented

2023-02-10 23:12:12 +01:00

Member

Further testing shows that something seems to be breaking the JS that opens the modal dialog when certain strings are used for the cardID (i.e. just numbers).
Strings might need to be properly escaped during insertion.

Further testing shows that something seems to be breaking the JS that opens the modal dialog when certain strings are used for the cardID (i.e. just numbers). Strings might need to be properly escaped during insertion.

zotan referenced a pull request that will close this issue

2023-02-11 01:25:46 +01:00

Implement card deletion modals #24

zotan referenced this issue from a commit

2023-02-11 02:21:41 +01:00

Basic deletion dialog implemented

zotan closed this issue

2023-02-11 02:22:51 +01:00

No labels