From f85264b6f2e717f8358ce98cccd4f6d5971a48f0 Mon Sep 17 00:00:00 2001 From: Laura Hausmann Date: Mon, 30 Oct 2023 17:57:08 +0100 Subject: [PATCH] Update patches --- assets/policies.json | 1 + assets/prefs.js | 4 + patches/0005-disable-tab-shortcuts.patch | 111 ----------- patches/0005-shortcuts.patch | 242 +++++++++++++++++++++++ 4 files changed, 247 insertions(+), 111 deletions(-) delete mode 100644 patches/0005-disable-tab-shortcuts.patch create mode 100644 patches/0005-shortcuts.patch diff --git a/assets/policies.json b/assets/policies.json index 8fde7f7..e46c1b3 100644 --- a/assets/policies.json +++ b/assets/policies.json @@ -25,6 +25,7 @@ "https://addons.mozilla.org/firefox/downloads/latest/clearurls/latest.xpi", "https://addons.mozilla.org/firefox/downloads/latest/ipvfoo-pmarks/latest.xpi", "https://addons.mozilla.org/firefox/downloads/latest/jsonview/latest.xpi", + "https://addons.mozilla.org/firefox/downloads/latest/tab-session-manager/latest.xpi", "https://addons.mozilla.org/firefox/downloads/latest/return-youtube-dislikes/latest.xpi", "https://addons.mozilla.org/firefox/downloads/latest/shinigami-eyes/latest.xpi", "https://addons.mozilla.org/firefox/downloads/latest/sponsorblock/latest.xpi", diff --git a/assets/prefs.js b/assets/prefs.js index d13ae8e..4ae028b 100644 --- a/assets/prefs.js +++ b/assets/prefs.js @@ -6,6 +6,10 @@ lockPref("browser.uidensity", 1); lockPref("browser.startup.page", 3); lockPref("layout.css.system-ui.enabled", false); +// Allow custom search engines +pref("browser.urlbar.update2.engineAliasRefresh", true); // No clue why this needs both pref and lockPref but here we are +lockPref("browser.urlbar.update2.engineAliasRefresh", true); + // Workaround for https://bugzilla.mozilla.org/show_bug.cgi?id=1420777 lockPref("network.http.http2.coalesce-hostnames", false); diff --git a/patches/0005-disable-tab-shortcuts.patch b/patches/0005-disable-tab-shortcuts.patch deleted file mode 100644 index de0704d..0000000 --- a/patches/0005-disable-tab-shortcuts.patch +++ /dev/null @@ -1,111 +0,0 @@ -diff --git a/browser/base/content/browser-sets.inc b/browser/base/content/browser-sets.inc -index d08984b796330..ec2b46f95f6ff 100644 ---- a/browser/base/content/browser-sets.inc -+++ b/browser/base/content/browser-sets.inc -@@ -75,8 +75,8 @@ - - - -- -- -+# -+# - - - -@@ -341,15 +341,15 @@ - #define NUM_SELECT_TAB_MODIFIER accel - #endif - --#expand --#expand --#expand --#expand --#expand --#expand --#expand --#expand --#expand -+# #expand -+# #expand -+# #expand -+# #expand -+# #expand -+# #expand -+# #expand -+# #expand -+# #expand - - IsControl() && aKeyboardEvent->mKeyCode == NS_VK_TAB) { -+ return; -+ } -+ - // Shift focus forward or back depending on shift key - bool isDocMove = aKeyboardEvent->IsControl() || - aKeyboardEvent->mKeyCode == NS_VK_F6; diff --git a/patches/0005-shortcuts.patch b/patches/0005-shortcuts.patch new file mode 100644 index 0000000..28337a0 --- /dev/null +++ b/patches/0005-shortcuts.patch @@ -0,0 +1,242 @@ +diff --git a/browser/base/content/tabbrowser.js b/browser/base/content/tabbrowser.js +index f1d264d84fec8..ca0367a34ca23 100644 +--- a/browser/base/content/tabbrowser.js ++++ b/browser/base/content/tabbrowser.js +@@ -5641,14 +5641,14 @@ + + case ShortcutUtils.NEXT_TAB: + if (AppConstants.platform == "macosx") { +- this.tabContainer.advanceSelectedTab(1, true); +- aEvent.preventDefault(); ++// this.tabContainer.advanceSelectedTab(1, true); ++// aEvent.preventDefault(); + } + break; + case ShortcutUtils.PREVIOUS_TAB: + if (AppConstants.platform == "macosx") { +- this.tabContainer.advanceSelectedTab(-1, true); +- aEvent.preventDefault(); ++// this.tabContainer.advanceSelectedTab(-1, true); ++// aEvent.preventDefault(); + } + break; + } +diff --git a/toolkit/content/widgets/tabbox.js b/toolkit/content/widgets/tabbox.js +index 997e8413f2a22..178c1dee73632 100644 +--- a/toolkit/content/widgets/tabbox.js ++++ b/toolkit/content/widgets/tabbox.js +@@ -134,20 +134,20 @@ + true + ); + if (this.tabs && this.handleCtrlTab) { +- this.tabs.advanceSelectedTab(event.shiftKey ? -1 : 1, true); +- event.preventDefault(); ++// this.tabs.advanceSelectedTab(event.shiftKey ? -1 : 1, true); ++// event.preventDefault(); + } + break; + case ShortcutUtils.PREVIOUS_TAB: + if (this.tabs) { +- this.tabs.advanceSelectedTab(-1, true); +- event.preventDefault(); ++// this.tabs.advanceSelectedTab(-1, true); ++// event.preventDefault(); + } + break; + case ShortcutUtils.NEXT_TAB: + if (this.tabs) { +- this.tabs.advanceSelectedTab(1, true); +- event.preventDefault(); ++ // this.tabs.advanceSelectedTab(1, true); ++// event.preventDefault(); + } + break; + } +diff --git a/dom/events/EventStateManager.cpp b/dom/events/EventStateManager.cpp +index 01c7ed0125d69..33c915f3e3cf5 100644 +--- a/dom/events/EventStateManager.cpp ++++ b/dom/events/EventStateManager.cpp +@@ -3379,6 +3379,12 @@ void EventStateManager::PostHandleKeyboardEvent( + EnsureDocument(presContext); + nsFocusManager* fm = nsFocusManager::GetFocusManager(); + if (fm && mDocument) { ++ ++ // We don't care about tab movement, it's handled by Sidebery ++ if (aKeyboardEvent->IsControl() && aKeyboardEvent->mKeyCode == NS_VK_TAB) { ++ return; ++ } ++ + // Shift focus forward or back depending on shift key + bool isDocMove = aKeyboardEvent->IsControl() || + aKeyboardEvent->mKeyCode == NS_VK_F6; +diff --git a/browser/base/content/browser-sets.inc b/browser/base/content/browser-sets.inc +index d08984b796330..3b32785b3b3cc 100644 +--- a/browser/base/content/browser-sets.inc ++++ b/browser/base/content/browser-sets.inc +@@ -75,8 +75,8 @@ + + + +- +- ++# ++# + + + +@@ -167,7 +167,7 @@ + modifiers="accel" + #endif + command="Tools:Downloads"/> +- ++# + + + +@@ -179,13 +179,8 @@ + modifiers="accel" + internal="true"/> + + + + #else +- ++ + + + +@@ -341,15 +336,15 @@ + #define NUM_SELECT_TAB_MODIFIER accel + #endif + +-#expand +-#expand +-#expand +-#expand +-#expand +-#expand +-#expand +-#expand +-#expand ++# #expand ++# #expand ++# #expand ++# #expand ++# #expand ++# #expand ++# #expand ++# #expand ++# #expand + + + +- ++ + + + +diff --git a/dom/events/ShortcutKeyDefinitions.cpp b/dom/events/ShortcutKeyDefinitions.cpp +index 3f34f45240444..bdf404b1e90b0 100644 +--- a/dom/events/ShortcutKeyDefinitions.cpp ++++ b/dom/events/ShortcutKeyDefinitions.cpp +@@ -176,7 +176,7 @@ ShortcutKeyData ShortcutKeys::sInputHandlers[] = { + {u"keypress", nullptr, u"x", u"accel", u"cmd_cut"}, // Win, macOS, Linux, Android, Emacs + {u"keypress", nullptr, u"v", u"accel", u"cmd_paste"}, // Win, macOS, Linux, Android, Emacs + {u"keypress", nullptr, u"z", u"accel", u"cmd_undo"}, // Win, macOS, Linux, Android, Emacs +- {u"keypress", nullptr, u"z", u"accel,shift", u"cmd_redo"}, // Win, macOS, Linux, Android, Emacs ++ {u"keypress", nullptr, u"y", u"accel", u"cmd_redo"}, // Win, macOS, Linux, Android, Emacs + + {u"keypress", nullptr, u"v", u"accel,shift", u"cmd_paste"}, // Win, macOS, Linux, Android, Emacs + // Mac uses Option+Shift+Command+V for Paste and Match Style +@@ -184,11 +184,6 @@ ShortcutKeyData ShortcutKeys::sInputHandlers[] = { + {u"keypress", nullptr, u"v", u"accel,alt,shift", u"cmd_paste"}, // macOS + #endif // MOZ_WIDGET_COCOA + +-#if defined(XP_WIN) || defined(MOZ_WIDGET_GTK) ||\ +- defined(USE_EMACS_KEY_BINDINGS) +- {u"keypress", nullptr, u"y", u"accel", u"cmd_redo"}, // Win, Linux, Emacs +-#endif // XP_WIN || MOZ_WIDGET_GTK || USE_EMACS_KEY_BINDINGS +- + #if defined(XP_WIN) || defined(MOZ_WIDGET_COCOA) || defined(MOZ_WIDGET_GTK) ||\ + defined(MOZ_WIDGET_ANDROID) + {u"keypress", nullptr, u"a", u"accel", u"cmd_selectAll"}, // Win, macOS, Linux, Android +@@ -365,12 +360,7 @@ ShortcutKeyData ShortcutKeys::sTextAreaHandlers[] = { + {u"keypress", nullptr, u"x", u"accel", u"cmd_cut"}, // Win, macOS, Linux, Android, Emacs + {u"keypress", nullptr, u"v", u"accel", u"cmd_paste"}, // Win, macOS, Linux, Android, Emacs + {u"keypress", nullptr, u"z", u"accel", u"cmd_undo"}, // Win, macOS, Linux, Android, Emacs +- {u"keypress", nullptr, u"z", u"accel,shift", u"cmd_redo"}, // Win, macOS, Linux, Android, Emacs +- +-#if defined(XP_WIN) || defined(MOZ_WIDGET_GTK) ||\ +- defined(USE_EMACS_KEY_BINDINGS) +- {u"keypress", nullptr, u"y", u"accel", u"cmd_redo"}, // Win, Linux, Emacs +-#endif // XP_WIN || MOZ_WIDGET_GTK || USE_EMACS_KEY_BINDINGS ++ {u"keypress", nullptr, u"y", u"accel", u"cmd_redo"}, // Win, macOS, Linux, Android, Emacs + + #if defined(XP_WIN) || defined(MOZ_WIDGET_COCOA) || defined(MOZ_WIDGET_GTK) ||\ + defined(MOZ_WIDGET_ANDROID) +@@ -561,17 +551,13 @@ ShortcutKeyData ShortcutKeys::sBrowserHandlers[] = { + {u"keypress", nullptr, u"v", u"accel", u"cmd_paste"}, // Win, macOS, Linux, Android, Emacs + {u"keypress", nullptr, u"v", u"accel,shift", u"cmd_pasteNoFormatting"}, // Win, macOS, Linux, Android, Emacs + {u"keypress", nullptr, u"z", u"accel", u"cmd_undo"}, // Win, macOS, Linux, Android, Emacs +- {u"keypress", nullptr, u"z", u"accel,shift", u"cmd_redo"}, // Win, macOS, Linux, Android, Emacs ++ {u"keypress", nullptr, u"y", u"accel", u"cmd_redo"}, // Win, macOS, Linux, Android, Emacs + + // Mac uses Option+Shift+Command+V for Paste and Match Style + #if defined(MOZ_WIDGET_COCOA) + {u"keypress", nullptr, u"v", u"accel,alt,shift", u"cmd_pasteNoFormatting"}, // macOS + #endif // MOZ_WIDGET_COCOA + +-#if defined(XP_WIN) +- {u"keypress", nullptr, u"y", u"accel", u"cmd_redo"}, // Win +-#endif // XP_WIN +- + {u"keypress", nullptr, u"a", u"accel", u"cmd_selectAll"}, // Win, macOS, Linux, Android, Emacs + #if defined(USE_EMACS_KEY_BINDINGS) + {u"keypress", nullptr, u"a", u"alt", u"cmd_selectAll"}, // Emacs +@@ -730,18 +716,13 @@ ShortcutKeyData ShortcutKeys::sEditorHandlers[] = { + {u"keypress", nullptr, u"v", u"accel", u"cmd_paste"}, // Win, macOS, Linux, Android, Emacs + {u"keypress", nullptr, u"v", u"accel,shift", u"cmd_pasteNoFormatting"}, // Win, macOS, Linux, Android, Emacs + {u"keypress", nullptr, u"z", u"accel", u"cmd_undo"}, // Win, macOS, Linux, Android, Emacs +- {u"keypress", nullptr, u"z", u"accel,shift", u"cmd_redo"}, // Win, macOS, Linux, Android, Emacs ++ {u"keypress", nullptr, u"y", u"accel", u"cmd_redo"}, // Win, macOS, Linux, Android, Emacs + + // Mac uses Option+Shift+Command+V for Paste and Match Style + #if defined(MOZ_WIDGET_COCOA) + {u"keypress", nullptr, u"v", u"accel,alt,shift", u"cmd_pasteNoFormatting"}, // macOS + #endif // MOZ_WIDGET_COCOA + +-#if defined(XP_WIN) || defined(MOZ_WIDGET_GTK) ||\ +- defined(USE_EMACS_KEY_BINDINGS) +- {u"keypress", nullptr, u"y", u"accel", u"cmd_redo"}, // Emacs +-#endif // XP_WIN || MOZ_WIDGET_GTK || USE_EMACS_KEY_BINDINGS +- + #if defined(XP_WIN) || defined(MOZ_WIDGET_COCOA) || defined(MOZ_WIDGET_GTK) ||\ + defined(MOZ_WIDGET_ANDROID) + {u"keypress", nullptr, u"a", u"accel", u"cmd_selectAll"}, // Win, macOS, Linux, Android